[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: dfa MT-safe?
|
From: |
Paul Eggert |
|
Subject: |
Re: dfa MT-safe? |
|
Date: |
Mon, 16 Dec 2019 01:03:19 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 12/15/19 4:43 AM, address@hidden wrote:
> On the assumption that setlocale is the only blocker, I would rather
> see an additional `char *locale_name' parameter added to dfa_syntax.
Thanks, this is a good suggestion. Running with it, we can improve it further by
putting this new flag into struct localeinfo (so no need for a new dfasyntax
parameter), and also I think I can initialize it without using setlocale (so no
need to worry about setlocale's lack of thread-safety). I installed the attached
patches and they work with 'grep'. This way, we shouldn't need to pull in any
more Gnulib code into Gawk.
I plan to take a look at the more serious crashes soon.
0001-localeinfo-record-whether-locale-is-simple.patch
Description: Text Data
0002-dfa-make-dfasyntax-thread-safe.patch
Description: Text Data