Re: dfa MT-safe?

[arnold]

Paul Eggert <address@hidden> wrote:

> On 12/15/19 4:43 AM, address@hidden wrote:
> > On the assumption that setlocale is the only blocker, I would rather
> > see an additional `char *locale_name' parameter added to dfa_syntax.
>
> Thanks, this is a good suggestion. Running with it, we can improve it further 
> by
> putting this new flag into struct localeinfo (so no need for a new dfasyntax
> parameter), and also I think I can initialize it without using setlocale (so 
> no
> need to worry about setlocale's lack of thread-safety). I installed the 
> attached
> patches and they work with 'grep'. This way, we shouldn't need to pull in any
> more Gnulib code into Gawk.
>
> I plan to take a look at the more serious crashes soon.

I will manually apply these changes and test, but they look
reasonable to me.

I won't be able to merge from gnulib until the dfa crashes are
dealt with, though.  IMHO those are very high priority.

Thanks,

Arnold