bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #66504] [gropdf] build failure on Solaris 10


From: Deri James
Subject: [bug #66504] [gropdf] build failure on Solaris 10
Date: Tue, 3 Dec 2024 11:50:50 -0500 (EST)

Follow-up Comment #4, bug #66504 (group groff):

Hi Branden,

Please can you test this patch on your Solaris.

diff --git a/src/devices/gropdf/gropdf.pl b/src/devices/gropdf/gropdf.pl
index 754c4904b..5186b02d3 100644
--- a/src/devices/gropdf/gropdf.pl
+++ b/src/devices/gropdf/gropdf.pl
@@ -486,7 +486,7 @@ my $term="\n";
 my @bl;
 my %seac;
 my $thisfnt;
-my $parcln=qr/\[[^\]]*?\]|(?<term>.)((?!\g{term}).)*\g{term}/;
+my $parcln=qr/\[[^\]]*?\]|(.)((?!\1).)*\1/;
 my $parclntyp=qr/(?:[\d\w]|\([+-]?[\S]{2}|$parcln)/;
 
 if (!GetOptions('F=s' => \$fd, 'I=s' => \@idirs, 'l' => \$frot,
@@ -1697,10 +1697,16 @@ sub do_x
                    else
                    {
                        my $dim=`( identify $FDnm 2>/dev/null || file $FDnm )`;
-                       $dim=~m/(?:(?:[,=A-Z]|JP2)
(?<w>\d+)\s*x\s*(?<h>\d+))|(?:height=(?<h>\d+).+width=(?<w>\d+))/;
-
-                       $info->{ImageWidth}=$+{w};
-                       $info->{ImageHeight}=$+{h};
+                       if ($dim=~m/(?:[,=A-Z]|JP2) (\d+)\s*x\s*(\d+)/)
+                       {
+                           $info->{ImageWidth}=$1;
+                           $info->{ImageHeight}=$2;
+                       }
+                       elsif ($dim=~m/height=(\d+).+width=(\d+)/)
+                       {
+                           $info->{ImageWidth}=$2;
+                           $info->{ImageHeight}=$1;
+                       }
 
                        if ($dim=~m/JPEG \d+x|JFIF/)
                        {

If it compiles, happy for you to commit, whether it "works" is a different
matter, given dependencies on pdfinfo, file, identify, perlmagick, ImageMagick
>= 6.0, for different levels of "working", which may not be available.

Without any of these dependencies .PDFPIC fails, the only thing which will
still work is \X'pdf: pdfpic file.pdf ...'.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66504>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]