[bug #66537] tmac/pdfpic.tmac: missing ", qq(\\n)" before a perl 'if' command

[Deri James]

Follow-up Comment #2, bug #66537 (group groff):

Hi Bjarni,

I know that you produce the hdtbl examples as pdfs (we don't), so my first
issue is to make the minimum changes so that I can reproduce mixed_plckles as
a pdf. Please can you confirm that these two changes are sufficient:-

diff --git a/contrib/hdtbl/examples/mixed_pickles.roff
b/contrib/hdtbl/examples/mixed_pickles.roff
index dfbd9194b..eddd6fcc6 100644
--- a/contrib/hdtbl/examples/mixed_pickles.roff
+++ b/contrib/hdtbl/examples/mixed_pickles.roff
@@ -45,7 +45,7 @@ Call groff with options \-t, \-e, and \-p!
 .      TBL width='25% 75%' csp=.5n cpd=.5n hal=c
 .        TR
 .          TD hl=d vl=d rowspan=2 bgc=red4 fgc=linen fsz=1.2 fst=HB val=m
-.            PSPIC -I -\\n[.l]u gnu.eps
+.            PDFPIC -I -\\n[.l]u doc/gnu.eps
 .            sp .5
 .            nop eps image with \fI.PSPIC\fP
 .          TD bgc=linen
diff --git a/contrib/hdtbl/hdtbl.am b/contrib/hdtbl/hdtbl.am
index 85f0b2328..e5e51523f 100644
--- a/contrib/hdtbl/hdtbl.am
+++ b/contrib/hdtbl/hdtbl.am
@@ -114,7 +114,7 @@ SUFFIXES += .roff .in .ps
 
 .roff.ps:
        $(GROFF_V)$(MKDIR_P) `dirname $@` \
-       && $(HDTBLGROFF) -Tps $< >$@
+       && $(HDTBLGROFF) -Tpdf $< >$@
 
 .in.roff:
        $(AM_V_GEN)$(MKDIR_P) `dirname $@` \

Please note that the output file is still .ps but it is a pdf, and it is
necessary to include doc/ with the filename. The reason for this is because
.PSPIC uses psbb (which I assume can access the -I (include) directories), but
.PDFPIC has no access to the list of directories. Gropdf itself does have
access to the include directories so \X'pdf: pdfpic gnu.eps' (without doc/)
would find the file.

You don't actually say what problem you observe when producing mixed_plckles
your way, but I see no errors, and I have attached the file the above changes
produced.

(file #56680)

    _______________________________________________________

Additional Item Attachment:

File name: mixed_pickles.ps               Size: 16KiB
    <https://file.savannah.gnu.org/file/mixed_pickles.ps?file_id=56680>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-f13d333523abc00b8bb10e20cbe61e83bc26ec2a.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66537>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature