[bug #66537] tmac/pdfpic.tmac: missing ", qq(\\n)" before a perl 'if' command

[Deri James]

Follow-up Comment #3, bug #66537 (group groff):


> Hi,
> 
> I have added the difference between master and my version of "hdtbl.am", and
> "mixed_pickles.roff"; plus the used "gnu.pdf" file to the attachments.
> 
> You need to change the option "-ww" to "-wall" to get rid of extra warnings
> from the master version.

Hi Bjarni,

Your patches applied cleanly, but unfortunately, when running make, I get:-

 cd .. && /bin/sh /home/derij/groff-git/groff/build-aux/missing automake-1.16
--gnu Makefile
 cd . && /bin/sh ./config.status Makefile depfiles
config.status: creating Makefile
config.status: executing depfiles commands
make  all-recursive
make[1]: Entering directory '/home/derij/groff-git/groff/build'
make[2]: Entering directory '/home/derij/groff-git/groff/build'
make[2]: *** No rule to make target 'contrib/hdtbl/examples/fonts.dvi_n.in',
needed by 'contrib/hdtbl/examples/fonts.dvi_n.roff'.  Stop.
make[2]: Leaving directory '/home/derij/groff-git/groff/build'
make[1]: *** [Makefile:10778: all-recursive] Error 1
make[1]: Leaving directory '/home/derij/groff-git/groff/build'
make: *** [Makefile:6505: all] Error 2

So I reverted to my single line change to hdtbl.am (detailed in my previous
comment), just so I could build a pdf using your custom mixed_plckles.roff.
Placed the gnu.pdf in doc/, and ran make. No warnings or errors and I can't
see any problem with the attached pdf. I also ran it using ../doc/gnu.xpm, so
both code paths in pdfpic.tmac have been exercised and both pdf results look
Ok with no warnings.

You have not told me the problem you are seeing with the current code, or is
it just a concern regarding the symetry of the code?

I use this test script to validate the image handling in .PDFPIC and gropdf:-

illus113.jpg
.PDFPIC -L ./illus113.jpg 3i
Valence4.jpg
.PDFPIC -L ./Valence4.jpg 3i
DyBase.png
.PDFPIC -L ./DyBase.png 3i
DyBase.pnm
.PDFPIC -L ./DyBase.pnm 3i
500kb.png
.PDFPIC -L ./500kb.png 3i
Free_Test_Data_1.1MB_TIFF.tif
.PDFPIC -L ./Free_Test_Data_1.1MB_TIFF.tif 3i
Free_Test_Data_128KB_JPG.jpg
.PDFPIC -L ./Free_Test_Data_128KB_JPG.jpg 3i
Transparent.png
.PDFPIC -L ./Transparent.png 3i
Transparent.jpg
.PDFPIC -L ./Transparent.jpg 3i
Transparent16.png
.PDFPIC -L ./Transparent16.png 3i
Transparent16.jpg
.PDFPIC -L ./Transparent16.jpg 3i
Transparent16.jpeg
.PDFPIC -L ./Transparent16.jpeg 3i
Transparent16w.png
.PDFPIC -L ./Transparent16w.png 3i
Transparent8.png
.PDFPIC -L ./Transparent8.png 3i
Small.png~
.PDFPIC -L ./Small.png~ 3i
Small.png
.PDFPIC -L ./Small.png 3i
Small2.png
.PDFPIC -L ./Small2.png 3i
Small3.png
.PDFPIC -L ./Small3.png 3i
16bit-000.ppm
.PDFPIC -L ./16bit-000.ppm 3i
16bit-001.ppm
.PDFPIC -L ./16bit-001.ppm 3i
GW.png
.PDFPIC -L ./GW.png 3i
GW.jpg
.PDFPIC -L ./GW.jpg 3i
GW-000.ppm
.PDFPIC -L ./GW-000.ppm 3i
GW-000.png
.PDFPIC -L ./GW-000.png 3i
GW16.png
.PDFPIC -L ./GW16.png 3i
mdr16.tiff
.PDFPIC -L ./mdr16.tiff 3i
multi-ai.jpg
.PDFPIC -L ./multi-ai.jpg 3i
Transparent16_cmyk.tif
.PDFPIC -L ./Transparent16_cmyk.tif 3i
Transparent16.g.png
.PDFPIC -L ./Transparent16.g.png 3i
Transparent16.ppm
.PDFPIC -L ./Transparent16.ppm 3i
Valence16.jpg
.PDFPIC -L ./Valence16.jpg 3i
FT.ppm
.PDFPIC -L ./FT.ppm 3i
Transparent16.g.jpg
.PDFPIC -L ./Transparent16.g.jpg 3i
sample-heif-files-sample-5.pnm
.PDFPIC -L ./sample-heif-files-sample-5.pnm 3i
sample-heif-files-sample-5.jp2
.PDFPIC -L ./sample-heif-files-sample-5.jp2 3i
sample-heif-files-sample-5.heif
.PDFPIC -L ./sample-heif-files-sample-5.heif 3i

Which tests many different formats, colour models, transparency, bit depth,
etc. and the code appears to work correctly.

(file #56682)

    _______________________________________________________

Additional Item Attachment:

File name: mixed_pickles.pdf              Size: 26KiB
    <https://file.savannah.gnu.org/file/mixed_pickles.pdf?file_id=56682>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-f13d333523abc00b8bb10e20cbe61e83bc26ec2a.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66537>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature