Re: [RFC PATCH glibc 24/34] hurd: Only check for TLS initialization inside rtld or in static builds

[Samuel Thibault]

Hello,

Sergey Bugaev, le jeu. 13 avril 2023 15:17:51 +0300, a ecrit:
> I have now sent the second version of
> that patch, please try applying it and test if that fixes it.

I'll give it a try.

> Please also check if the other reply port tweak you reverted today is
> also innocent.

The same tests fail, but differently :)

€ ./testrun.sh  signal/tst-signal --direct
Set handler.
Sending myself signal 15.
Received signal 15 (Terminated).
Fatal glibc error: ../sysdeps/mach/hurd/mig-reply.c:92 
(__mig_dealloc_reply_port): assertion failed: port == arg
Abandon (core dumped)

#0  0x01027a5c in __GI___mach_msg_trap ()
    at /usr/src/glibc-upstream/build/mach/mach_msg_trap.S:2
2       kernel_trap (__mach_msg_trap,-25,7)
[Current thread is 1 (process 20128)]
(gdb) bt
#0  0x01027a5c in __GI___mach_msg_trap ()
    at /usr/src/glibc-upstream/build/mach/mach_msg_trap.S:2
#1  0x010281f6 in __GI___mach_msg (msg=0x10017d0, option=3, send_size=48,
    rcv_size=32, rcv_name=31, timeout=0, notify=0) at msg.c:111
#2  0x012eb1e8 in __msg_sig_post (process=27, signal=6, sigcode=0, refport=35)
    at /usr/src/glibc-upstream/build/hurd/RPC_msg_sig_post.c:158
#3  0x01074dbc in kill_port (refport=<optimized out>, msgport=<optimized out>)
    at ../sysdeps/mach/hurd/kill.c:67
#4  kill_pid (pid=pid@entry=20128) at ../sysdeps/mach/hurd/kill.c:104
#5  0x0107509c in __GI___kill (pid=<optimized out>, sig=<optimized out>)
    at ../sysdeps/mach/hurd/kill.c:138
#6  0x01074242 in __GI_raise (signo=6) at ../sysdeps/htl/raise.c:52
#7  __GI_raise (signo=6) at ../sysdeps/htl/raise.c:34
#8  0x010277b1 in __GI_abort () at abort.c:79
#9  0x0102791c in __libc_message (fmt=<optimized out>)
    at ../sysdeps/posix/libc_fatal.c:150
#10 0x0106bc20 in __libc_assert_fail (assertion=0x1222762 "port == arg",
    file=0x121c2a0 "../sysdeps/mach/hurd/mig-reply.c", line=92,
    function=0x121c2c4 <__PRETTY_FUNCTION__.0> "__mig_dealloc_reply_port")
    at __libc_assert_fail.c:31
#11 0x010283d2 in __GI___mig_dealloc_reply_port (arg=<optimized out>)
    at ../sysdeps/mach/hurd/mig-reply.c:92
#12 0x012eb23e in __msg_sig_post (process=27, signal=15, sigcode=0, refport=35)
    at /usr/src/glibc-upstream/build/hurd/RPC_msg_sig_post.c:160
#13 0x01074dbc in kill_port (refport=<optimized out>, msgport=<optimized out>)
    at ../sysdeps/mach/hurd/kill.c:67
#14 kill_pid (pid=pid@entry=20128) at ../sysdeps/mach/hurd/kill.c:104
#15 0x0107509c in __GI___kill (pid=<optimized out>, sig=<optimized out>)
    at ../sysdeps/mach/hurd/kill.c:138
#16 0x01074242 in __GI_raise (signo=15) at ../sysdeps/htl/raise.c:52
#17 __GI_raise (signo=15) at ../sysdeps/htl/raise.c:34
#18 0x010075ac in ?? ()
#19 0x0105d88f in __libc_start_call_main (argv=0x0, argc=16807472, main=0x2)
    at ../sysdeps/generic/libc_start_call_main.h:23
#20 __libc_start_main_impl (main=0x2, argc=16807472, argv=0x0, init=0x1007657,
    fini=0x1007540, rtld_fini=0x2, stack_end=0x1001d54)
    at ../csu/libc-start.c:360

I have put these on
https://dept-info.labri.fr/~thibault/tmp/libc.so
https://dept-info.labri.fr/~thibault/tmp/ld.so
https://dept-info.labri.fr/~thibault/tmp/core


Samuel