Re: [RFC PATCH glibc v2 26/34] hurd: Remove __hurd_local_reply_port

[Samuel Thibault]

Hello,

Sergey Bugaev, le jeu. 13 avril 2023 16:20:50 +0300, a ecrit:
> On Thu, Apr 13, 2023 at 4:12 PM Samuel Thibault <samuel.thibault@gnu.org> 
> wrote:
>     at ../sysdeps/mach/hurd/dl-sysdep.c:241
> > 241       __mig_dealloc_reply_port (MACH_PORT_NULL);
> 
> Uhh, who deallocs a reply port like that :| You can't pass random crap
> into __mig_dealloc_reply_port and rely on its particular
> implementation, which *happened* to deallocate the current port.
> 
> Apparently FATAL_PREPARE in dl-sysdep.h is also defined to do the same.
> 
> I'd rather fix these both to do
> __mig_dealloc_reply_port (__mig_get_reply_port ());

That looks reasonable to me, yes.

Samuel