bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH glibc v2 26/34] hurd: Remove __hurd_local_reply_port


From: Samuel Thibault
Subject: Re: [RFC PATCH glibc v2 26/34] hurd: Remove __hurd_local_reply_port
Date: Sat, 15 Apr 2023 08:45:46 +0200
User-agent: NeoMutt/20170609 (1.8.3)

Hello,

Sergey Bugaev, le ven. 14 avril 2023 23:29:51 +0300, a ecrit:
> On Fri, Apr 14, 2023 at 8:33 PM Samuel Thibault <samuel.thibault@gnu.org> 
> wrote:
> > Applied with fixing the __mig_dealloc_reply_port(NULL) cases, thanks!
> 
> By the way: that __mig_dealloc_reply_port () inside
> _dl_sysdep_start_cleanup () is not doing what the author of that code
> wanted it to do. It deallocates the current reply port, but while
> doing that, it creates a fresh one in its place.

You mean with the __mach_port_deallocate calls?

> It would be nice to not deallocate __mach_{task,host}_self_ too, and
> instead migrate them into the new libc.so slots.

That'd need different variables names, but that should be doable easily
by redirecting __mach_task_self in mach_init.h dependening on building
ld.so.

> Besides, are we 100% sure that after initially entering libc.so, ld.so
> will never do any Mach things (RPCs) anymore?

AIUI all the OS-dependent things that ld.so calls comes from
dl-sysdep.c, so as long as all these are weak functions, we're safe.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]