Re: [Denemo-devel] A major re-structuring.

[Richard Shann]

I notice that the integration test fails on the Restructure branch as
follows:
FAIL: integration
=================

# random seed: R02Sd28539b8964e97939f19411d1c36202f
# Start of integration tests
Opening /home/rshann/git-denemo/denemo/tests/fixtures/denemo/blank.denemo
ok 1 /integration/open-blank-file
ok 2 /integration/open-and-save-blank-file
# Start of open-and-save-complex-file- tests
# Start of home tests
# Start of rshann tests
# Start of git-denemo tests
# Start of denemo tests
Opening /home/rshann/git-denemo/denemo/examples/ReminderAccidental.denemo
Finding and reopening 
/home/rshann/git-denemo/denemo/tests/tmp/denemo/ReminderAccidental.denemo
Comparing 
/home/rshann/git-denemo/denemo/examples/ReminderAccidental.denemo with 
/home/rshann/git-denemo/denemo/tests/tmp/denemo/ReminderAccidental.denemo
ok 3 
/integration/open-and-save-complex-file-/home/rshann/git-denemo/denemo/examples-.denemo-1
**
ERROR:integration.c:193:test_open_save_complex_file: child process 
(/integration/open-and-save-complex-file-/home/rshann/git-denemo/denemo/examples-.denemo-2
 [31747]) failed unexpectedly
Opening /home/rshann/git-denemo/denemo/examples/HandWrittenSlurs.denemo
# ERROR:integration.c:193:test_open_save_complex_file: child process 
(/integration/open-and-save-complex-file-/home/rshann/git-denemo/denemo/examples-.denemo-2
 [31747]) failed unexpectedly
Aborted

I've tried opening and saving examples/ReminderAccidental.denemo and
examples/HandWrittenSlurs.denemo by hand and the resultant saved file is
identical. I don't know how to debug the tests :( in particular, why it
is reporting these two particular files...

Richard



On Thu, 2016-03-10 at 15:14 +0000, Richard Shann wrote:
> One of the most fundamental mistakes made when Denemo was first started
> was not to have a structure for a Denemo measure. Instead it is just a
> list of the objects in the measure. As a knock on effect, nothing can be
> stored with the measure that applies to the whole measure.
> This has made it difficult to fix the way that information about the
> context (clef, timesignature ...) of an object is stored, especially
> when a measure has no objects. It has long been my ambition to get rid
> of the way the calculation of the context information is computed - a
> draw time. This is still causing failures in Check Score on occasions.
> 
> As a start I have created a branch Restructure in which a staff now has
> a list of Measure structures, which for now just has one element, viz.
> the list of objects.
> 
> I've done a first trawl of all the code to try and make the change work
> properly, and I've tested (with the default build) loading files,
> starting new files, adding and deleting movements, staffs, measures,
> notes, chords, copy and paste creating snippets, pasting and following
> them Undo and Redo.
> 
> It would not surprise me if I have missed something, it is perilous
> work. The symptoms of an error are crashes, often with memory allocation
> warnings. But, so far it seems good. If anyone can help testing this
> version that would be good!
> 
> Richard
> 
> 
> 
> _______________________________________________
> Denemo-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/denemo-devel