Re: Patches for Emacs 25.2

[Michael Albinus]

Dmitry Gutov <address@hidden> writes:

> Hi Michael,

Hi Dmitry,

>> !              (nconc (if msg-file
>> !                         (list
>> !                     "commit" "-F"
>> !                     (or (file-remote-p msg-file 'localname)  msg-file))
>
> Can't we move the (file-remote-p ... 'localname) call to the first
> hunk here? Then the patch will only change one place, and we get rid
> of the added `or' here.

I let it to Nikolay. However, given that this construct

  (or (file-remote-p FILE 'localname) FILE)

happens several times in the lisp sources, I wonder whether we shall
give it an own defmacro or defsubst (in master, of course).