|
From: | Dmitry Gutov |
Subject: | Re: Patches for Emacs 25.2 |
Date: | Mon, 7 Nov 2016 11:36:22 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 |
On 07.11.2016 11:01, Michael Albinus wrote:
Can't we move the (file-remote-p ... 'localname) call to the first hunk here? Then the patch will only change one place, and we get rid of the added `or' here.I let it to Nikolay.
Not sure I understand.
However, given that this construct (or (file-remote-p FILE 'localname) FILE) happens several times in the lisp sources, I wonder whether we shall give it an own defmacro or defsubst (in master, of course).
I have no strong opinion either way, but your commit in master fixing this problem does not have this construct.
[Prev in Thread] | Current Thread | [Next in Thread] |