[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ash, lsh: Avoid code duplication
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] ash, lsh: Avoid code duplication |
Date: |
Mon, 21 Nov 2016 19:14:50 +0200 |
> From: Tino Calancha <address@hidden>
> CC: address@hidden, Tino Calancha <address@hidden>
> Date: Tue, 22 Nov 2016 01:20:51 +0900
>
> Thank you. Following is the new patch after your comments:
We are close.
> +Lisp_Object
> +ash_lsh_impl (register Lisp_Object value, Lisp_Object count, bool lsh)
static Lisp_Object
ash_lsh_impl (register Lisp_Object value, Lisp_Object count, bool lsh)
> diff --git a/src/lisp.h b/src/lisp.h
> index e087828..c48c2c8 100644
> --- a/src/lisp.h
> +++ b/src/lisp.h
> @@ -602,6 +602,7 @@ extern void char_table_set (Lisp_Object, int,
> Lisp_Object);
> /* Defined in data.c. */
> extern _Noreturn Lisp_Object wrong_type_argument (Lisp_Object, Lisp_Object);
> extern _Noreturn void wrong_choice (Lisp_Object, Lisp_Object);
> +Lisp_Object ash_lsh_impl (Lisp_Object, Lisp_Object, bool);
No need to declare it here, as it is a static function used only in
the file in which it is defined.
Thanks.
- [PATCH] ash, lsh: Avoid code duplication, Tino Calancha, 2016/11/21
- Re: [PATCH] ash, lsh: Avoid code duplication, Eli Zaretskii, 2016/11/21
- Re: [PATCH] ash, lsh: Avoid code duplication, Tino Calancha, 2016/11/21
- Re: [PATCH] ash, lsh: Avoid code duplication,
Eli Zaretskii <=
- Re: [PATCH] ash, lsh: Avoid code duplication, Tino Calancha, 2016/11/21
- Re: [PATCH] ash, lsh: Avoid code duplication, Eli Zaretskii, 2016/11/22
- Re: [PATCH] ash, lsh: Avoid code duplication, Tino Calancha, 2016/11/22
- Re: [PATCH] ash, lsh: Avoid code duplication, Tino Calancha, 2016/11/26
- Re: [PATCH] ash, lsh: Avoid code duplication, Davis Herring, 2016/11/22