Re: [PATCH] ash, lsh: Avoid code duplication

[Davis Herring]

> > --- a/src/lisp.h
> > +++ b/src/lisp.h
> > @@ -602,6 +602,7 @@ extern void char_table_set (Lisp_Object, int, Lisp_Object);
> >  /* Defined in data.c.  */
> >  extern _Noreturn Lisp_Object wrong_type_argument (Lisp_Object, Lisp_Object);
> >  extern _Noreturn void wrong_choice (Lisp_Object, Lisp_Object);
> > +Lisp_Object ash_lsh_impl (Lisp_Object, Lisp_Object, bool);
>
> No need to declare it here, as it is a static function used only in
> the file in which it is defined.

In case it helps explain the issue, note that the "extern" here did 
nothing substantive: functions are extern if not static, and the extern 
keyword isn't needed to prevent a function declaration being a definition.

Davis

--
This product is sold by volume, not by mass.  If it appears too dense or 
too sparse, it is because mass-energy conversion has occurred during 
shipping.