Re: [PATCH] Unit tests and lexical-binding for delim-col.el

[Basil L. Contovounesios]

Stefan Kangas <address@hidden> writes:

> Noam Postavsky <address@hidden> writes:
>> I think you may as well go with defun here, delimit-columns-str isn't
>> being used in some performance-critical spot, as far as I can tell.
>
> You are probably correct.  However, I decided to leave Basil's changes as is,
> since I don't know what would conventionally be considered cleaner/better in
> this case.

It is always better to use defun until proven otherwise, see (info
"(elisp) Inline Functions").  The only reason I used defsubst was to be
more conservative, but if no-one minds then defun is indeed preferable.

Thanks,

-- 
Basil