[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Unit tests and lexical-binding for delim-col.el
From: |
Basil L. Contovounesios |
Subject: |
Re: [PATCH] Unit tests and lexical-binding for delim-col.el |
Date: |
Thu, 09 May 2019 14:39:46 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Stefan Kangas <address@hidden> writes:
> I just got back the confirmation for the copyright assignment.
Great. Can someone please check that it's indeed on file? I don't
think I have access to that information.
> If there are no more outstanding issues, I think this is ready to be
> merged.
Once the assignment is confirmed on our side as well, and if no-one
objects within the next few days, I or someone else will push the patch
to master.
> I've attached the patch (again) with a better commit message and
> proper thanks given to Basil.
Thanks, I noticed an additional possible cleanup:
diff --git a/lisp/delim-col.el b/lisp/delim-col.el
index a968b32052..910178020d 100644
--- a/lisp/delim-col.el
+++ b/lisp/delim-col.el
@@ -5,8 +5,8 @@
;; Author: Vinicius Jose Latorre <address@hidden>
;; Maintainer: Vinicius Jose Latorre <address@hidden>
;; Version: 2.1
-;; Keywords: internal
-;; X-URL: http://www.emacswiki.org/cgi-bin/wiki/ViniciusJoseLatorre
+;; Keywords: convenience text
+;; X-URL: https://www.emacswiki.org/emacs/ViniciusJoseLatorre
;; This file is part of GNU Emacs.
@@ -125,6 +125,7 @@ columns
"Prettify columns."
:link '(emacs-library-link :tag "Source Lisp File" "delim-col.el")
:prefix "delimit-columns-"
+ :group 'convenience
:group 'text)
(defcustom delimit-columns-str-before ""
Any objections?
Thanks,
--
Basil
- [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/07
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/07
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Noam Postavsky, 2019/05/07
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/08
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/08
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/08
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/08
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el,
Basil L. Contovounesios <=
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Monnier, 2019/05/09
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/11
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Basil L. Contovounesios, 2019/05/20
- Re: [PATCH] Unit tests and lexical-binding for delim-col.el, Stefan Kangas, 2019/05/30