Re: Towards a cleaner build

[Eli Zaretskii]

> From: Lars Ingebrigtsen <address@hidden>
> Cc: address@hidden
> Date: Fri, 17 May 2019 12:24:40 +0200
> 
> > Yes, it's called string-make-unibyte ;-)
> >
> > I'm not sure we have anything else, but let me dwell on this for a
> > while.
> 
> Ok.  :-)
> 
> > Btw, your other change in select.el was incorrect, and I reverted it.
> > For starters, when we need to _decode_ text (which is what
> > gui-get-selection does, since it imports text into Emacs), it can
> > never be TRT to _encode_ it.
> 
> Oh, sorry; thinko.
> 
> > In general (with the possible exception of Gnus ;-), the places where
> > we left those string-make/to/as-uni/multibyte thingies are there not
> > because we were lazy, but because the replacements are either not
> > trivial or don't exist.
> 
> Right.  Should we slap a with-no-warnings around this call, then?

Maybe, but let me dwell on that as well.

> > The deprecation message's advice in most of
> > these cases is simply misleading.  So I welcome work on these places,
> > but my advice is to discuss each one of them before making changes,
> > lest we break the code in some more or less subtle use cases.
> 
> Will do.

Thanks.