Re: [PATCH] Simplify Gnus buffer liveness checking and killing

[Eric Abrahamsen]

"Basil L. Contovounesios" <address@hidden> writes:

> Eric Abrahamsen <address@hidden> writes:
>
>> "Basil L. Contovounesios" <address@hidden> writes:
>>
>>> There seems to be overlap in the implementations and usage of
>>> gnus-buffer-exists-p and gnus-buffer-live-p, as well as of gnus-buffers
>>> and gnus-prune-buffers.
>>>
>>> The attached patch removes gnus-buffer-exists-p in favour of a modified
>>> gnus-buffer-live-p, aliases gnus-prune-buffers to a simplified
>>> gnus-buffers, and simplifies several call sites pertaining to buffer
>>> liveness checking and killing.  WDYT?
>>
>> I've been running this most of today; nothing terrible has happened so
>> far.
>
> Thanks for testing.
>
>> Can I suggest adding `gnus-buffer-exists-p' back in as a
>> `define-obsolete-function-alias' for `gnus-buffer-live-p'?
>
> Drats, I was hoping to get away with that one. ;)

Nope, there'll always be someone to complain :)

>> I assume that will work for macros.
>
> Yes, so long as the macroexpansion sites are recompiled.
>
>> Anyway, it would just be nicer for people who, ahem, have external
>> packages that were using that function.
>
> I could have sworn I checked GNU ELPA before removing it...  Probably
> got mixed up with some other branch I had on the back-burner, sorry.

No worries! Looks like my gnorb package was the only one using it, anyway.