[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Replace XChar2b with unsigned in all font backends
From: |
Andy Moreton |
Subject: |
Re: Replace XChar2b with unsigned in all font backends |
Date: |
Mon, 20 May 2019 23:52:30 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2.50 (windows-nt) |
On Mon 20 May 2019, Eli Zaretskii wrote:
> On May 20, 2019 7:29:34 PM GMT+01:00, Andy Moreton <address@hidden> wrote:
>> Please revert this patch to fix the build on master, and then revisit
>> these changes after that.
>>
> You ask to revert because you don't think there's a way of fixing this
> without reverting? Or fof some other reason?
The first order of business is to restore master to a usable state.
After that, any amount of time can be taken to revise the non-working
patch into something that does not cause the regression.
"Don't break the build" is an important rule. A recent Rx patch was
reverted by its author because it broke bootstrapping, and then a
revised version added later after the problem with the original patch
had been fixed. Why should this patch be any different ?
AndyM
- Replace XChar2b with unsigned in all font backends, martin rudalics, 2019/05/20
- Re: Replace XChar2b with unsigned in all font backends, Andy Moreton, 2019/05/20
- Re: Replace XChar2b with unsigned in all font backends, Alex Gramiak, 2019/05/20
- Re: Replace XChar2b with unsigned in all font backends, Andy Moreton, 2019/05/20
- Re: Replace XChar2b with unsigned in all font backends, Eli Zaretskii, 2019/05/20
- Re: Replace XChar2b with unsigned in all font backends,
Andy Moreton <=
- Re: Replace XChar2b with unsigned in all font backends, Eli Zaretskii, 2019/05/21
- Re: Replace XChar2b with unsigned in all font backends, Andy Moreton, 2019/05/21
- Re: Replace XChar2b with unsigned in all font backends, Eli Zaretskii, 2019/05/21
- Re: Replace XChar2b with unsigned in all font backends, Alex Gramiak, 2019/05/20
Re: Replace XChar2b with unsigned in all font backends, Alex Gramiak, 2019/05/20
Re: Replace XChar2b with unsigned in all font backends, Andy Moreton, 2019/05/21