[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master ae7fe26 1/3: ; Fix my previous commit
From: |
Stefan Kangas |
Subject: |
Re: master ae7fe26 1/3: ; Fix my previous commit |
Date: |
Thu, 28 Jan 2021 20:19:14 -0800 |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * lisp/generic-x.el (generic-mode-ini-file-find-file-hook): Fix my
>> previous commit; for some reason 'function' produces a warning here
>> while 'quote' does not.
> [...]
>> (define-obsolete-function-alias 'generic-mode-ini-file-find-file-hook
>> - #'ini-generic-mode-find-file-hook "28.1"))
>> + 'ini-generic-mode-find-file-hook "28.1"))
>
> The problem is that most of the `defun`s in this file are not at top
> level but inside a `when`. This is ugly and should be fixed.
Yes, that was my diagnosis as well. I suppose one could argue that this
warning is a bug, but it hardly seems worth fixing: this use-case is not
something we should encourage. So I installed the workaround.
> We should throw out `generic-extras-enable-list`.
Agreed. I guess it only exists for historical reasons?
BTW, is there any reason why the modes in generic-x.el are not
autoloaded and in auto-mode-alist? I did not know that (require
'generic-x) was a thing until today, and I do remember at times missing
the syntax highlighting of some of the files it supports.