[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default |
Date: |
Tue, 18 May 2021 11:45:10 +0300 |
User-agent: |
K-9 Mail for Android |
On May 18, 2021 11:17:04 AM GMT+03:00, "Paul W. Rankin via Emacs development
discussions." <emacs-devel@gnu.org> wrote:
> On 2021-05-18 16:58, Karl Fogel wrote:
> > On 18 May 2021, Paul W. Rankin" via "Emacs development discussions.
> > wrote:
> >> Ugh. Not sure how this slipped into master but it is not a
> >> good/considerate idea to set default value of bookmark-fontify to
> t.
> >>
> >> If there are no reasonable objections I'll push this later today.
> >
> > I don't have a strong opinion either way, but if you're curious as
> to
> > where this came from, it was here:
> >
> > The discussion in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48179
> > is quite long, so it might be worth reading before reverting.
>
> Hi Karl,
>
> The discussion there only seems to account for compatibility with
> package bm.el, not the more general "avoid pushing your idea onto
> everyone" idea. And given the overlay is temporary, it's quite opaque
> for the average person to inspect it to see what's actually happening.
>
> It's so ugly my first thought was that something had broken rather
> than
> this was actually an intentional feature.
>
> I'm going to commit this without further discussion -- which hopefully
>
> should remind others to take the more considerate route when
> introducing
> new features!
Please don't make this change until you hear from Lars, who examined the
original patch and decided to install it. It doesn't get more "considerate"
than that.
- [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Paul W. Rankin, 2021/05/18
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Karl Fogel, 2021/05/18
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Paul W. Rankin, 2021/05/18
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Eli Zaretskii, 2021/05/18
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Lars Ingebrigtsen, 2021/05/18
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Eli Zaretskii, 2021/05/18
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Lars Ingebrigtsen, 2021/05/18
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Bastien, 2021/05/19
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Eli Zaretskii, 2021/05/19
- Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Lars Ingebrigtsen, 2021/05/24
- RE: [External] : Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default, Drew Adams, 2021/05/24