Re: emacs-29 00de296d1b 3/3: Simplify erc-sasl's auth-source API

[Po Lu]

Amin Bandali <bandali@gnu.org> writes:

> branch: emacs-29
> commit 00de296d1b4f629fd828cdeff588bb4f742d9ffe
> Author: F. Jason Park <jp@neverwas.me>
> Commit: Amin Bandali <bandali@gnu.org>
>
>     Simplify erc-sasl's auth-source API
>     
>     * doc/misc/erc.texi: Revise descriptions in SASL chapter to reflect
>     simplified auth-source options.
>     
>     * lisp/erc/erc-sasl.el (erc-sasl-password,
>     erc-sasl-auth-source-function): Revise doc strings.
>     (erc-sasl-auth-source-password-as-host): New function to serve as
>     more useful choice for option `erc-sasl-auth-source-function'.
>     (erc-sasl--read-password): Promote auth-source to pole position, above
>     an explicit string and `:password'.
>     
>     * test/lisp/erc/erc-sasl-tests.el (erc-sasl--read-password--basic):
>     Massage tests to conform to simplified `erc-sasl-password'
>     API.  (Bug#29108.)

Was such a big change really a regression fix, suitable for emacs-29?