[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] notifications: Allow to use Icon Naming Specification for
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH v3] notifications: Allow to use Icon Naming Specification for app-icon |
Date: |
Wed, 26 Jul 2023 18:23:39 +0300 |
> From: Andrew Tropin <andrew@trop.in>
> Date: Wed, 26 Jul 2023 15:59:48 +0400
>
> Icon is not always a file name, but can be just an icon name.
> https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
Thanks, but there's too much passive voice in the documentation parts,
please try to improve that. For example:
> +If value is a string @code{expand-file-name} will be applied, if value
> +is a symbol it will be used as is (helpful when using Icon Naming
> +Specification).
I would rephrase (which also clarifies the stuff a bit):
If the value is a string, the function interprets it as a file name
and converts to absolute by using @code{expand-file-name}; if it is
a symbol, the function will use its name (which is useful when using
the Icon Naming Specification).
> +*** Allow to use Icon Naming Specification for app-icon.
> +Symbol can be used as a value for :app-icon to provide icon name
> +without specifying a file.
"You can use a symbol as the value ..."
- Re: [PATCH] notifications: Don't expand-file-name app-icon., (continued)
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Eli Zaretskii, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Michael Albinus, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Eli Zaretskii, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Michael Albinus, 2023/07/26
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Eli Zaretskii, 2023/07/26
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Matthias Meulien, 2023/07/26
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Michael Albinus, 2023/07/26
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Matthias Meulien, 2023/07/26
[PATCH v2] notifications: Allow to use Icon Naming Specification for app-icon, Andrew Tropin, 2023/07/26
[PATCH v3] notifications: Allow to use Icon Naming Specification for app-icon, Andrew Tropin, 2023/07/26
[PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Andrew Tropin, 2023/07/27
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Michael Albinus, 2023/07/27
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Eli Zaretskii, 2023/07/27
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Michael Albinus, 2023/07/27
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Andrew Tropin, 2023/07/28
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Michael Albinus, 2023/07/28
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Eli Zaretskii, 2023/07/28
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Michael Albinus, 2023/07/28