[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon |
Date: |
Fri, 28 Jul 2023 14:07:19 +0300 |
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> Date: Fri, 28 Jul 2023 09:24:58 +0200
>
> Andrew Tropin <andrew@trop.in> writes:
>
> >> Done as commit 42a911c61e67caa807750cd40887b729f09aaf52.
> >
> > Thank you!
>
> You're welcome.
>
> I've digged the documentation further, and it seems like we've overlooked,
> that XDG icon names are possible already, via the :image-path argument:
>
> (notifications-notify :title "I am playing music" :image-path
> "multimedia-player")
>
> So the patch wasn't necessary. I'm a little bit undecided, whether we
> shall revert it. Eli?
If you are unhappy with leaving it, I don't object to reverting. But
if it currently causes no harm, perhaps leave it for now, and let's
see if it's useful for some use cases.
- [PATCH v3] notifications: Allow to use Icon Naming Specification for app-icon, (continued)
- [PATCH v3] notifications: Allow to use Icon Naming Specification for app-icon, Andrew Tropin, 2023/07/26
- [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Andrew Tropin, 2023/07/27
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Michael Albinus, 2023/07/27
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Eli Zaretskii, 2023/07/27
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Michael Albinus, 2023/07/27
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Andrew Tropin, 2023/07/28
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Michael Albinus, 2023/07/28
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon,
Eli Zaretskii <=
- Re: [PATCH v4] notifications: Allow to use Icon Naming Specification for app-icon, Michael Albinus, 2023/07/28