[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/eglot ce983d1 47/69: Revert "Treat null/nil server capa
From: |
João Távora |
Subject: |
[elpa] externals/eglot ce983d1 47/69: Revert "Treat null/nil server capabilities as false" |
Date: |
Sun, 20 Oct 2019 08:21:50 -0400 (EDT) |
branch: externals/eglot
commit ce983d1fc3d777beaba1c7e472bf819511605bb0
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>
Revert "Treat null/nil server capabilities as false"
This reverts commit 6d87de16c5f86c5479db5e6705f0fb93fe727d3e.
A capability of "null" is downright invalid, and must NOT be mistaken
for a value of "{}" (which indicates the presence of the capability)
or "False" (which indicates its asence). See
https://github.com/microsoft/language-server-protocol/issues/830#issuecomment-537849292
for a clarification from the LSP maintainer.
---
eglot.el | 3 ---
1 file changed, 3 deletions(-)
diff --git a/eglot.el b/eglot.el
index ef7f8f0..d1a1a3d 100644
--- a/eglot.el
+++ b/eglot.el
@@ -1113,9 +1113,6 @@ under cursor."
for probe = (plist-member caps feat)
if (not probe) do (cl-return nil)
if (eq (cadr probe) :json-false) do (cl-return nil)
- ;; If the server specifies null as the value of the capability, it
- ;; makes sense to treat it like false.
- if (null (cadr probe)) do (cl-return nil)
if (not (listp (cadr probe))) do (cl-return (if more nil (cadr
probe)))
finally (cl-return (or (cadr probe) t)))))
- [elpa] externals/eglot b4f3028 18/69: Fix #223: use a less buggy Flymake, (continued)
- [elpa] externals/eglot b4f3028 18/69: Fix #223: use a less buggy Flymake, João Távora, 2019/10/20
- [elpa] externals/eglot 6c884c4 24/69: Fix #263: fix case when eglot-put-doc-in-help-buffer is nil, João Távora, 2019/10/20
- [elpa] externals/eglot e28b396 25/69: Fix #259: work around a bug in Emacs's change detection, João Távora, 2019/10/20
- [elpa] externals/eglot 2372bc8 30/69: Fixed extra ) in python example snippet (#287), João Távora, 2019/10/20
- [elpa] externals/eglot 6d87de1 35/69: Treat null/nil server capabilities as false, João Távora, 2019/10/20
- [elpa] externals/eglot 7f31f29 36/69: Use gopls server as the default for Go (#304), João Távora, 2019/10/20
- [elpa] externals/eglot 4548202 28/69: Simplify eldoc usage (#269), João Távora, 2019/10/20
- [elpa] externals/eglot 36b7cf32 38/69: Fix #272: also use signature label offsets for parameter info, João Távora, 2019/10/20
- [elpa] externals/eglot 059ea59 43/69: Optionally shutdown after killing last buffer of managed project (#309), João Távora, 2019/10/20
- [elpa] externals/eglot 59ba0b1 39/69: New README section on how to best report bugs to Eglot, João Távora, 2019/10/20
- [elpa] externals/eglot ce983d1 47/69: Revert "Treat null/nil server capabilities as false",
João Távora <=
- [elpa] externals/eglot 4693abf 50/69: Fix #258: Allow user to set idle time to wait before processing changes, João Távora, 2019/10/20
- [elpa] externals/eglot 14ab804 54/69: Fix #318: unbreak xref-find-definitions, João Távora, 2019/10/20
- [elpa] externals/eglot dbb5dd4 57/69: Slightly more robust completion tests, João Távora, 2019/10/20
- [elpa] externals/eglot 3604173 64/69: Unbreak eglot--setq-saving if symbol is unbound, João Távora, 2019/10/20
- [elpa] externals/eglot a11a41b 63/69: Use of company-capf backend in eglot-managed buffers, João Távora, 2019/10/20
- [elpa] externals/eglot 6e93622 27/69: Fix #273: leniently handle invalid positions sent by some servers, João Távora, 2019/10/20
- [elpa] externals/eglot 254fee0 46/69: Use more pyls and less rls in tests, João Távora, 2019/10/20
- [elpa] externals/eglot 0e5e08d 51/69: Support goto-{declaration, implementation, typeDefinition}, João Távora, 2019/10/20
- [elpa] externals/eglot 5a21670 59/69: Fix bug in workspace/didChangeWatchedfiles, João Távora, 2019/10/20
- [elpa] externals/eglot 9359c15 58/69: Close #316: add support for the Ada Language Server, João Távora, 2019/10/20