emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org-remark f9157062bc 2/4: fix: remove TEXT argment fro


From: ELPA Syncer
Subject: [elpa] externals/org-remark f9157062bc 2/4: fix: remove TEXT argment from mark command
Date: Sun, 25 Dec 2022 12:57:55 -0500 (EST)

branch: externals/org-remark
commit f9157062bc0902308dfd571dc438ac259028c835
Author: Noboru Ota <me@nobiot.com>
Commit: Noboru Ota <me@nobiot.com>

    fix: remove TEXT argment from mark command
---
 README.org    | 18 +++++++++---------
 org-remark.el | 15 +++++++--------
 2 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/README.org b/README.org
index 281be01ff9..0ec5274791 100644
--- a/README.org
+++ b/README.org
@@ -118,31 +118,31 @@ This macro was inspired by 
[[https://github.com/jkitchin/ov-highlight][Ov-highli
 
 ** org-remark-notes-send-data
 :PROPERTIES:
-:org-remark-beg: 39511
-:org-remark-end: 39537
+:org-remark-beg: 39420
+:org-remark-end: 39446
 :org-remark-id: 4de1f10c
 :org-remark-label: nil
-:org-remark-link: [[file:org-remark.el::984]]
+:org-remark-link: [[file:org-remark.el::982]]
 :org-remark-note-body: [empty entry]
 :END:
 
 ** org-remark-highlights-load
 :PROPERTIES:
-:org-remark-beg: 39628
-:org-remark-end: 39654
+:org-remark-beg: 39537
+:org-remark-end: 39563
 :org-remark-id: bf05b18c
 :org-remark-label: nil
-:org-remark-link: [[file:org-remark.el::988]]
+:org-remark-link: [[file:org-remark.el::986]]
 :org-remark-note-body: [empty entry]
 :END:
 
 ** goto
 :PROPERTIES:
-:org-remark-beg: 33838
-:org-remark-end: 33842
+:org-remark-beg: 33747
+:org-remark-end: 33751
 :org-remark-id: 184667c4
 :org-remark-label: nil
-:org-remark-link: [[file:org-remark.el::852]]
+:org-remark-link: [[file:org-remark.el::850]]
 :org-remark-note-body: This is no longer empty.
 :END:
 This is no longer empty.
diff --git a/org-remark.el b/org-remark.el
index df77c782b4..22d746e11d 100644
--- a/org-remark.el
+++ b/org-remark.el
@@ -341,7 +341,7 @@ recommended to turn it on as part of Emacs initialization.
 
 (add-to-list 'org-remark-available-pens #'org-remark-mark)
 ;;;###autoload
-(defun org-remark-mark (beg end &optional id text mode)
+(defun org-remark-mark (beg end &optional id mode)
   "Apply face `org-remark-highlighter' to the region between BEG and END.
 
 When this function is used interactively, it will generate a new
@@ -362,18 +362,14 @@ back to the database.
 MODE is also an argument which can be passed from Elisp.  It
 determines whether or not highlight is to be saved in the
 marginal notes file.  The expected values are nil, :load and
-:change.
-
-TEXT is an excerpt of the body text of the marginal note (for
-:load and :change modes only)."
+:change."
   (interactive (org-remark-region-or-word))
   ;; FIXME
   ;; Adding "nil" is different to removing a prop
   ;; This will do for now
   (org-remark-highlight-mark beg end id mode
                              nil nil
-                             (list 'org-remark-label "nil"
-                                   'help-echo text)))
+                             (list 'org-remark-label "nil")))
 
 (when org-remark-create-default-pen-set
   ;; Create default pen set.
@@ -709,8 +705,10 @@ to the database."
                                         beg end
                                         (overlay-properties ov)
                                         (org-remark-highlight-get-title))
+              ;;; Get props for create and change any way
            (message "org-remark: Highlights not saved; buffer is not visiting 
a file")))
        ;;; on load, send data once from notes to source
+
        (when (eq mode :load)
          (org-remark-notes-communicate-with-source filename id)))))
   ;;; for on-going communication from notes to source, after-save-hook.
@@ -1008,7 +1006,8 @@ load the highlights"
       (let ((fn (intern (concat "org-remark-mark-" label))))
         (unless (functionp fn) (setq fn #'org-remark-mark))
         (funcall fn beg end id :load)
-        ;; TODO Generalize. TEXT should not be the fixed property.
+        ;; TODO Generalize the part that updates properties.
+        ;; :body should not be the fixed property.
         ;; '(:text (val . fn) :prop1 (val . fn) :prop2 (val .fn))
         ;; (dolist list)
         (let ((ov (org-remark-find-overlay-at-point beg)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]