[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 8358f0c1e2 2/2: Make obsolete unused 'denote-fil
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote 8358f0c1e2 2/2: Make obsolete unused 'denote-file-directory-p' |
Date: |
Mon, 22 May 2023 23:58:14 -0400 (EDT) |
branch: externals/denote
commit 8358f0c1e24ff21dd464690ce8a8639dc420440e
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Make obsolete unused 'denote-file-directory-p'
---
denote.el | 8 +-------
tests/denote-test.el | 9 ---------
2 files changed, 1 insertion(+), 16 deletions(-)
diff --git a/denote.el b/denote.el
index 404867d8f1..ae6f7b6fcb 100644
--- a/denote.el
+++ b/denote.el
@@ -663,13 +663,7 @@ and use one of the extensions implied by
`denote-file-type'."
(string-match-p denote-signature-regexp
(file-name-nondirectory file))))
-(defun denote-file-directory-p (file)
- "Return non-nil if FILE is a directory.
-Omit FILE if it matches the value of user option
-`denote-excluded-directories-regexp'."
- (and (file-directory-p file)
- denote-excluded-directories-regexp
- (not (string-match-p denote-excluded-directories-regexp file))))
+(make-obsolete 'denote-file-directory-p nil "2.0.0")
(defun denote-file-has-supported-extension-p (file)
"Return non-nil if FILE has supported extension.
diff --git a/tests/denote-test.el b/tests/denote-test.el
index 5bc3f50a3c..87c317abec 100644
--- a/tests/denote-test.el
+++ b/tests/denote-test.el
@@ -149,14 +149,5 @@ and use one of the extensions implied by
`denote-file-type'."
(should
(denote-file-has-signature-p "20230522T154900==sig--test__keyword.txt")))
-;; TODO 2023-05-22: Check the solution to the FIXME above and proceed
-;; accordingly.
-
-;; (ert-deftest denote-test--denote-file-directory-p ()
-;; "Test that `denote-file-directory-p' returns non-nil on a directory.
-;; The function should return nil if the directory it checks for is
-;; matched by the user option `denote-excluded-directories-regexp'."
-;; (should
-
(provide 'denote-test)
;;; denote-test.el ends here