[nongnu] elpa/dslide 92b39b410f 131/230: interesting bug in custom action

[ELPA Syncer]

branch: elpa/dslide
commit 92b39b410fb100cacbf5bc6d13c3bb2e4b025b0d
Author: Psionik K <73710933+psionic-k@users.noreply.github.com>
Commit: Psionik K <73710933+psionic-k@users.noreply.github.com>

    interesting bug in custom action
    
    Due to editing this by hand, I accidentally did not include the if 
expression in
    the when-let expression.  As a result, the if could return t forever, 
meaning it
    was impossible to back up before this custom action.
    
    Return values are sensitive.  No way to protect the user from it except to
    hammer that fact home.
    
    Signed-off-by: Psionik K <73710933+psionic-k@users.noreply.github.com>
---
 README.org    | 14 +++++++-------
 test/demo.org |  4 ++--
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/README.org b/README.org
index 56d442ed65..5538ee0441 100644
--- a/README.org
+++ b/README.org
@@ -196,13 +196,13 @@ The ~dslide-section-next~  and ~dslide-section-previous~ 
method documentation ar
 
   (cl-defmethod dslide-backward ((obj dslide-action-red-paragraphs))
     (when-let* ((overlay (pop (oref obj overlays))))
-      (delete-overlay overlay))
-    ;; If there is a preceding overlay, move to its beginning else move to the
-    ;; beginning of the heading.
-    (if-let ((overlay (car (oref obj overlays))))
-        (prog1 t
-          (dslide-marker obj (overlay-start overlay)))
-      (dslide-marker obj (org-element-property :begin (dslide-heading obj)))))
+      (delete-overlay overlay)
+      ;; If there is a preceding overlay, move to its beginning else move to 
the
+      ;; beginning of the heading.
+      (if-let ((overlay (car (oref obj overlays))))
+          (prog1 t
+            (dslide-marker obj (overlay-start overlay)))
+        (dslide-marker obj (org-element-property :begin (dslide-heading 
obj))))))
 #+end_src
 
 ** Default Classes
diff --git a/test/demo.org b/test/demo.org
index 7460fad898..bb804ce551 100644
--- a/test/demo.org
+++ b/test/demo.org
@@ -81,13 +81,13 @@ The babel block below is a custom action supporting both 
forward, each step maki
 
   (cl-defmethod dslide-backward ((obj dslide-action-red-paragraphs))
     (when-let* ((overlay (pop (oref obj overlays))))
-      (delete-overlay overlay))
+      (delete-overlay overlay)
     ;; If there is a preceding overlay, move to its beginning else move to the
     ;; beginning of the heading.
     (if-let ((overlay (car (oref obj overlays))))
         (prog1 t
           (dslide-marker obj (overlay-start overlay)))
-      (dslide-marker obj (org-element-property :begin (dslide-heading obj)))))
+      (dslide-marker obj (org-element-property :begin (dslide-heading obj))))))
 #+end_src
 *** Custom Action Demo
 :PROPERTIES: