[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/dslide 93585c9173 158/230: slide composition order change
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/dslide 93585c9173 158/230: slide composition order change (soon to refactor) |
Date: |
Sun, 7 Jul 2024 19:00:31 -0400 (EDT) |
branch: elpa/dslide
commit 93585c9173e03dc0aece9b472bed36eb2bf8aed0
Author: Psionik K <73710933+psionic-k@users.noreply.github.com>
Commit: Psionik K <73710933+psionic-k@users.noreply.github.com>
slide composition order change (soon to refactor)
There was a hack in place to allow the narrowing action to work. This was
revealed to be buggy by embedding some section actions in a child.
Running the ordering in the originally intended way, with the slide always
encompassing the section and child actions, fixed an issue where nested
slides
with items could behave bizarrely when going backward.
Signed-off-by: Psionik K <73710933+psionic-k@users.noreply.github.com>
---
dslide.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dslide.el b/dslide.el
index a1a6e9b685..f146c463da 100644
--- a/dslide.el
+++ b/dslide.el
@@ -946,12 +946,12 @@ order.")
(child-action (oref obj child-action))
(slide-action (oref obj slide-action))
progress)
+ (unless (or progress (null slide-action))
+ (setq progress (dslide-forward slide-action)))
(while (and (not progress) section-actions)
(setq progress (dslide-forward (pop section-actions))))
(unless (or progress (null child-action))
(setq progress (dslide-forward child-action)))
- (unless (or progress (null slide-action))
- (setq progress (dslide-forward slide-action)))
progress))
(cl-defmethod dslide-backward ((obj dslide-slide))
@@ -961,10 +961,10 @@ order.")
progress)
(unless (null child-action)
(setq progress (dslide-backward child-action)))
- (while (and (not progress) section-actions)
- (setq progress (dslide-backward (pop section-actions))))
(unless (or progress (null slide-action))
(setq progress (dslide-backward slide-action)))
+ (while (and (not progress) section-actions)
+ (setq progress (dslide-backward (pop section-actions))))
progress))
;; `dslide--make-slide' is very critical to the user-facing configuration and
- [nongnu] elpa/dslide bf99a7df69 108/230: attr_methods -> atter_ms, (continued)
- [nongnu] elpa/dslide bf99a7df69 108/230: attr_methods -> atter_ms, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide aee6f28d4c 103/230: reasonable behavior for `ms-start-from' set to 'point, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 3547b1a1a7 107/230: rearranged demo, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 5956b98172 132/230: :results none in babel. really wish I could let-bind this, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide fe63ace5ca 144/230: empty presentation for test suite, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 92b39b410f 131/230: interesting bug in custom action, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 7f578b605a 130/230: old name left over, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 40b4bfe353 147/230: multiple animation overlays, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 91b8fcaf92 153/230: introducing dslide-deck-develop, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 64dc89cd0f 156/230: allow explicit 'none for slide action class, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 93585c9173 158/230: slide composition order change (soon to refactor),
ELPA Syncer <=
- [nongnu] elpa/dslide 00597b9770 155/230: customization reminders in the demo, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 77126167a3 159/230: remove extraneous method qualifiers, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 2ec658ec9e 162/230: reverse-in-place for children, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide a58a915104 163/230: understand progress from org elements, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 586082e591 165/230: set overlay initial height, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 6cf49d2625 181/230: Oh yeah, seq-find doesn't return the result, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 935224a638 182/230: ! introducing peel animation, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 217ddbe03e 185/230: a bit better display behavior, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 3a77163b15 188/230: ! hide markup action, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 04b2888a52 192/230: Hide markup action hides affiliated keywords, ELPA Syncer, 2024/07/07