[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] RFQ - new contribution - org-screenshot.el
From: |
Max Mikhanosha |
Subject: |
Re: [O] RFQ - new contribution - org-screenshot.el |
Date: |
Fri, 17 May 2013 06:41:20 -0400 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.6 Emacs/23.3.50 (x86_64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
At Fri, 17 May 2013 09:38:29 +0200,
Rainer M. Krug wrote:
>
> Nice and very useful. Can this be included in /contrib?
That is my intention, I have the FSF paper signed for Emacs and Org.
So what I'm looking for some minimum amount of eyes on the code, and
advice as to minimum set of things I need to adjust before committing it?
My list is.
1. Convert defvar to defcustom
2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in
dired.el
3. The prefix C-c M-s seems awkward but Org is so big everything else
is taken, and C-c C-x s is too close to C-c C-x C-s, which is
archive subtree (I initially had it there and moved after archiving
subtree by mistake)
Its its fine to go in as is, then its fine too, I'm pretty lazy :-)
Regards,
Max
Re: [O] RFQ - new contribution - org-screenshot.el, Feng Shu, 2013/05/17
Re: [O] RFQ - new contribution - org-screenshot.el, Max Mikhanosha, 2013/05/17