[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] RFQ - new contribution - org-screenshot.el
From: |
Feng Shu |
Subject: |
Re: [O] RFQ - new contribution - org-screenshot.el |
Date: |
Fri, 17 May 2013 21:17:21 +0800 |
User-agent: |
Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.2 (gnu/linux) |
Max Mikhanosha <address@hidden> writes:
> At Fri, 17 May 2013 09:38:29 +0200,
> Rainer M. Krug wrote:
>>
>> Nice and very useful. Can this be included in /contrib?
>
> That is my intention, I have the FSF paper signed for Emacs and Org.
>
> So what I'm looking for some minimum amount of eyes on the code, and
> advice as to minimum set of things I need to adjust before committing it?
>
> My list is.
>
> 1. Convert defvar to defcustom
>
> 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in
> dired.el
>
> 3. The prefix C-c M-s seems awkward but Org is so big everything else
> is taken, and C-c C-x s is too close to C-c C-x C-s, which is
> archive subtree (I initially had it there and moved after archiving
> subtree by mistake)
May be you shoule bind it to a mouse button! :-)
>
> Its its fine to go in as is, then its fine too, I'm pretty lazy :-)
>
> Regards,
> Max
--
Re: [O] RFQ - new contribution - org-screenshot.el, Feng Shu, 2013/05/17
Re: [O] RFQ - new contribution - org-screenshot.el, Max Mikhanosha, 2013/05/17
Re: [O] RFQ - new contribution - org-screenshot.el, François Pinard, 2013/05/20