[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Making org-agenda filters orthogonal and refreshed
From: |
Greg Tucker-Kellogg |
Subject: |
Re: [O] [PATCH] Making org-agenda filters orthogonal and refreshed |
Date: |
Sat, 19 Apr 2014 16:53:27 +0800 |
Hi Bastien,
Org-mode version 8.2.5h (release_8.2.5h-883-g45e881 @
/Users/gtk/.emacs.d/org/lisp/)
Sure, I'm happy to go with the FSF copyright agreement. I'll send the
request today.
Greg
On Sat, Apr 19, 2014 at 2:02 PM, Bastien <address@hidden> wrote:
> Hi Greg,
>
> Greg Tucker-Kellogg <address@hidden> writes:
>
>> This is org-mode version 8.2.5h, directly off the git.
>
> When mentioning the Org version for a patch you submit, please
> include the whole version with C-u M-x org-version RET -- this
> tells more than C-h v org-version.
>
>> emacs version 24.4.50.1
>>
>> I have noticed that combining top headline filters and category
>> filters didn't always work as documented.
>
> Thanks for looking into this.
>
> Before we go further enhancing the patch, are you willing to go with
> the FSF copyright assignment? I see you already have tiny changes and
> we cannot accept more. If you're not willing to sign, you'll drive
> the debugging and I'll write the code.
>
> Let me know.
>
> Other than that, the diagnosis is good and the patch looks okay,
> except for the use of defadvice.
>
> Thanks,
>
> --
> Bastien