[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] org-review-schedule
From: |
Bastien |
Subject: |
Re: [O] org-review-schedule |
Date: |
Sat, 19 Apr 2014 10:14:35 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
Hi Alan,
thanks for sharing -- some comments:
- you need to update the copyright of the file;
- example code in section 3 of the header is mangled;
- there are some dangling parentheses;
- use (get-text-property (point-min) ...) instead of
(get-text-property 1 ...)
- I'd use org-review instead of org-review-schedule as prefix;
- maybe you can use "naked" timestamps like 2014-04-19 sam.
instead of inactive ones, this way using "[" in the agenda
will not create false positives by inserting entries with
a REVIEW property.
- I infer from a quick read that this works for the agenda but
I guess this could work for both the agenda and Org buffers;
Since you took inspirationg from org-expiry, I guess some of
the comments above would apply there too... feel free to hack
into this directions for both org-expiry.el and org-review.el!
Actually, maybe both should be merged somehow, since expiring
is just reviewing entries to interactively delete them.
Thanks for this!
--
Bastien
- [O] org-review-schedule, Alan Schmitt, 2014/04/18
- Re: [O] org-review-schedule,
Bastien <=
- Re: [O] org-review-schedule, Alan Schmitt, 2014/04/19
- Re: [O] org-review-schedule, Alan Schmitt, 2014/04/25
- Re: [O] org-review-schedule, Nicolas Goaziou, 2014/04/25
- Re: [O] org-review-schedule, Alan Schmitt, 2014/04/25
- Re: [O] org-review-schedule, Nicolas Goaziou, 2014/04/25
- Re: [O] org-review-schedule, Alan Schmitt, 2014/04/27
- Re: [O] org-review-schedule, AW, 2014/04/28
- Re: [O] org-review-schedule, Alan Schmitt, 2014/04/28
- Re: [O] org-review-schedule, Alan Schmitt, 2014/04/26