[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[O] [PATCH 3/6] Fix org-table-sort-lines test
From: |
Sebastian Reuße |
Subject: |
[O] [PATCH 3/6] Fix org-table-sort-lines test |
Date: |
Sun, 11 Mar 2018 16:43:49 +0100 |
* test-org-table.el (test-org-table/sort-lines): Fix and improve
testcase.
Sorting and reversing «a C b» should result in «C b a», not in «b a
C». This test did not fail previously only because
org-table-sort-lines had an issue whereby sorts were always
case-sensitive.
---
testing/lisp/test-org-table.el | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/testing/lisp/test-org-table.el b/testing/lisp/test-org-table.el
index 850080c7a..d90caa8e9 100644
--- a/testing/lisp/test-org-table.el
+++ b/testing/lisp/test-org-table.el
@@ -1691,13 +1691,13 @@
(buffer-string))))
;; Sort alphabetically.
(should
- (equal "| a | x |\n| b | 4 |\n| c | 3 |\n"
- (org-test-with-temp-text "| <point>a | x |\n| c | 3 |\n| b | 4 |\n"
+ (equal "| a | x |\n| B | 4 |\n| c | 3 |\n"
+ (org-test-with-temp-text "| <point>a | x |\n| c | 3 |\n| B | 4 |\n"
(org-table-sort-lines nil ?a)
(buffer-string))))
(should
- (equal "| c | 3 |\n| b | 4 |\n| a | x |\n"
- (org-test-with-temp-text "| <point>a | x |\n| c | 3 |\n| b | 4 |\n"
+ (equal "| c | 3 |\n| B | 4 |\n| a | x |\n"
+ (org-test-with-temp-text "| <point>a | x |\n| c | 3 |\n| B | 4 |\n"
(org-table-sort-lines nil ?A)
(buffer-string))))
;; Sort alphabetically with case.
@@ -1707,7 +1707,7 @@
(org-table-sort-lines t ?a)
(buffer-string))))
(should
- (equal "| b |\n| a |\n| C |\n"
+ (equal "| C |\n| b |\n| a |\n"
(org-test-with-temp-text "| <point>a |\n| C |\n| b |\n"
(org-table-sort-lines nil ?A)
(buffer-string))))
--
2.16.2
- [O] [PATCH 1/6] Fix alphabetic sorting for tables, plain lists, Sebastian Reuße, 2018/03/11
- [O] [PATCH 2/6] Fix alphabetic string matching operators, Sebastian Reuße, 2018/03/11
- [O] [PATCH 3/6] Fix org-table-sort-lines test,
Sebastian Reuße <=
- [O] [PATCH 4/6] Fix string-collate-lessp shim, Sebastian Reuße, 2018/03/11
- [O] [PATCH 5/6] org-table-sort-lines: Fix case-sensitive sorting, Sebastian Reuße, 2018/03/11
- [O] [PATCH 6/6] Improve ‘org-sort-list’ test, Sebastian Reuße, 2018/03/11
- Re: [O] [PATCH 1/6] Fix alphabetic sorting for tables, plain lists, Nicolas Goaziou, 2018/03/13