[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 5/6] org-table-sort-lines: Fix case-sensitive sorting
|
From: |
Nicolas Goaziou |
|
Subject: |
Re: [O] [PATCH 5/6] org-table-sort-lines: Fix case-sensitive sorting |
|
Date: |
Tue, 13 Mar 2018 09:13:15 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Sebastian Reuße <address@hidden> writes:
> * org-table.el (org-table-sort-lines): Fix case sensitive sorting,
> improve docstring.
> * test-org-table.el (test-org-table/sort-lines): Enforce C locale when
> testing alphabetic sorting.
>
> ‘sort-subr’ ignores ‘sort-fold-case’ when a predicate is provided. To
> correctly handle case-sensitivity, we now bake it into the predicate.
>
> Since we are now sorting according to the user’s locale, WITH-CASE
> will not make a difference in most instances, since most locales
> always sort case-insensitively (cf. how GNU sort ignores the ‘-f’
> switch). We now mention this in the function docstring.
>
> In order to meaningfully test case-sensitive sorting, we now enforce
> the C locale in the respective unit test.
Applied. Thank you.
- [O] [PATCH 1/6] Fix alphabetic sorting for tables, plain lists, Sebastian Reuße, 2018/03/11
- [O] [PATCH 2/6] Fix alphabetic string matching operators, Sebastian Reuße, 2018/03/11
- [O] [PATCH 3/6] Fix org-table-sort-lines test, Sebastian Reuße, 2018/03/11
- [O] [PATCH 4/6] Fix string-collate-lessp shim, Sebastian Reuße, 2018/03/11
- [O] [PATCH 5/6] org-table-sort-lines: Fix case-sensitive sorting, Sebastian Reuße, 2018/03/11
- Re: [O] [PATCH 5/6] org-table-sort-lines: Fix case-sensitive sorting,
Nicolas Goaziou <=
- [O] [PATCH 6/6] Improve ‘org-sort-list’ test, Sebastian Reuße, 2018/03/11
- Re: [O] [PATCH 1/6] Fix alphabetic sorting for tables, plain lists, Nicolas Goaziou, 2018/03/13