|
From: | Maxim Nikulin |
Subject: | Re: [PATCH] org-agenda.el: Avoid dependency on subr-x |
Date: | Sat, 7 Aug 2021 00:10:29 +0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 05/08/2021 19:59, Timothy wrote:
Restore compatibility with Emacs-24.3.FYI Emacs 24 is no longer Org’s minimum version, from the next release onward it will be Emacs 25.
Timothy, I have seen that discussion. For me it does not matter in which way org-agenda.el will be fixed: by adding (require 'subr-x) or by using string= instead of string-empty-p. Both variants work with Emacs-26.3. The point is that "make single" should work without warnings and in the case of mixed install users should not get confusing errors that resemble real issues.
The only reason why I suggested namely to avoid string-empty-p is that compatibility with Emacs-24.3 is still declared in Org sources.
[Prev in Thread] | Current Thread | [Next in Thread] |