[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] org-agenda.el: Avoid dependency on subr-x
From: |
Timothy |
Subject: |
Re: [PATCH] org-agenda.el: Avoid dependency on subr-x |
Date: |
Sat, 07 Aug 2021 04:30:49 +0800 |
User-agent: |
mu4e 1.4.15; emacs 28.0.50 |
Hi Maxim,
> Timothy, I have seen that discussion. For me it does not matter in which way
> org-agenda.el will be fixed: by adding (require ’subr-x) or by using string=
> instead of string-empty-p. Both variants work with Emacs-26.3. The point is
> that
> “make single” should work without warnings and in the case of mixed install
> users should not get confusing errors that resemble real issues.
>
> The only reason why I suggested namely to avoid string-empty-p is that
> compatibility with Emacs-24.3 is still declared in Org sources.
Ah, cool. I took your original email to indicate that this change was solely for
Emacs 24.3 comparability, but I now see you simply used that as a reason to
choose between two different fixes.
All the best,
Timothy