Re: org-attach-sync uses directory-empty-p (new in Emacs 28)

[Maxim Nikulin]

On 12/08/2021 04:17, Marco Wahl wrote:
> Maxim Nikulin writes:
> > Compiling single /home/ubuntu/org-mode/lisp/org-compat.el...
> >
> > In end of data:
> > org-compat.el:1255:1:Warning: the function ‘directory-empty-p’ is not
> > known to
> >      be defined.
...
> How make the compiler happy?

I have never fought with this kind of problem. After looking at the 
other constructs in the org-compat.el file, I have tried

(if (fboundp 'directory-empty-p)
    (defalias 'org-directory-empty-p #'directory-empty-p)
  (defun org-directory-empty-p (dir)
    ; ...

I have no idea if there are any drawbacks of such approach, I can only 
say that such form suppresses the warning.

It seems, version comparison is sensible when an existing function gets 
new arguments, not in the case of completely new function.