Re: org-attach-sync uses directory-empty-p (new in Emacs 28)

[Marco Wahl]

Maxim Nikulin <manikulin@gmail.com> writes:

>>> Compiling single /home/ubuntu/org-mode/lisp/org-compat.el...
>>>
>>> In end of data:
>>> org-compat.el:1255:1:Warning: the function ‘directory-empty-p’ is not
>>> known to
>>>      be defined.

> I have never fought with this kind of problem. After looking at the
> other constructs in the org-compat.el file, I have tried
>
> (if (fboundp 'directory-empty-p)
>     (defalias 'org-directory-empty-p #'directory-empty-p)
>   (defun org-directory-empty-p (dir)
>     ; ...
>
> I have no idea if there are any drawbacks of such approach, I can only
> say that such form suppresses the warning.

Thanks Maxim and Kyle!

The latter suggestion landed in master a few minutes ago.


Have a great day!
--
Marco