[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking |
Date: |
Sat, 13 Aug 2022 14:42:07 +0800 |
Max Nikulin <manikulin@gmail.com> writes:
>> + (bare (and (string-match org-link-bracket-re l)
>> + (match-string 1 l))))
>> + (when bare
>> + (if (and org-babel-tangle-use-relative-file-links
>> + (string-match org-link-types-re bare)
>> + (string= (match-string 1 bare) "file"))
>
> It looks like (string-prefix-p "file:" bare) but without the complex
> regexp. I see, such code was used before. By the way, why it is "bare",
> not e.g. "target"?
match-end is used later in the code. Thus, string-match is justified.
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Bastien Guerry, 2022/08/03
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Ihor Radchenko, 2022/08/03
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Max Nikulin, 2022/08/03
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Hraban Luyat, 2022/08/10
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Ihor Radchenko, 2022/08/11
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Hraban Luyat, 2022/08/11
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Max Nikulin, 2022/08/12
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking,
Ihor Radchenko <=
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Max Nikulin, 2022/08/13
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Ihor Radchenko, 2022/08/13
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Ihor Radchenko, 2022/08/13
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Max Nikulin, 2022/08/11