[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking |
Date: |
Sun, 14 Aug 2022 11:20:36 +0800 |
Max Nikulin <manikulin@gmail.com> writes:
>>> It looks like (string-prefix-p "file:" bare) but without the complex
>>> regexp. I see, such code was used before. By the way, why it is "bare",
>>> not e.g. "target"?
>>
>> match-end is used later in the code. Thus, string-match is justified.
>
> The matched string is always "file:", so there is no actual point in
> `string-match'. It does not really matter however.
>
> (let ((params '((:tangle . "/home/user/file.el")))
> (type "file:")
> (target "file:///dev/null"))
> (if (and target
> org-babel-tangle-use-relative-file-links
> (string-prefix-p type target))
> (concat type
> (file-relative-name
> (substring target (length type))
> (file-name-directory (alist-get :tangle params))))
> target))
>
> In the code existed before and moved by the committed patch I do not
> like that "then" branch of the `if' form uses side effect of evaluation
> of the condition.
Sounds reasonable.
Could you make a patch?
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Bastien Guerry, 2022/08/03
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Ihor Radchenko, 2022/08/03
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Max Nikulin, 2022/08/03
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Hraban Luyat, 2022/08/10
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Ihor Radchenko, 2022/08/11
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Hraban Luyat, 2022/08/11
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Max Nikulin, 2022/08/12
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Ihor Radchenko, 2022/08/13
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Max Nikulin, 2022/08/13
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking,
Ihor Radchenko <=
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Ihor Radchenko, 2022/08/13
- Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking, Max Nikulin, 2022/08/11