[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)] |
Date: |
Mon, 16 Jan 2023 13:38:30 +0000 |
No Wayman <iarchivedmywholelife@gmail.com> writes:
> In order to properly generate org-version.el, the current build in
> mk/targets.mk requires a query of the repo's tags. Shallow clones
> do not have tags and so org-version will be generated as "N/A". In
> the attached patch, support for generating org-version.el from
> shallow clones is added. It is done by querying the upstream
> remote via git ls-remote and parsing the output. In this case, a
> more well formed org-version string will be generated. However, it
> will be missing the "commits since last tag" information. e.g.
>
> "release_9.6.1-n/a-gabc123"
As discussed, this is a reasonable addition.
However, I am concerned about the following scenario:
1. Shallow clone is created
2. make autoloads is issues when system is disconnected from internet
May it be properly handled? We can put N/A at the version tag as well in
such case.
What we should not have is "make autoloads" failing without internet.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], No Wayman, 2023/01/15
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], No Wayman, 2023/01/15
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)],
Ihor Radchenko <=
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], No Wayman, 2023/01/16
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], Ihor Radchenko, 2023/01/17
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], No Wayman, 2023/01/18
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], No Wayman, 2023/01/18
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], Ihor Radchenko, 2023/01/19
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], No Wayman, 2023/01/19
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], Ihor Radchenko, 2023/01/20
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], Max Nikulin, 2023/01/20
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], No Wayman, 2023/01/20
- Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)], Ihor Radchenko, 2023/01/21