[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix compat with emacs 25 due using temporary-file-directory
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] fix compat with emacs 25 due using temporary-file-directory |
Date: |
Mon, 16 Jan 2023 13:44:14 +0000 |
Tom Gillespie <tgbugs@gmail.com> writes:
> Small bugfix for emacs 25 compat. Best!
> (format "babel-stable-%d" (random 1000))
> - (temporary-file-directory))))
> + temporary-file-directory)))
Thanks!
Note that Emacs 25 is no longer officially supported. AFAIR, some Org
components are already failing in Emacs 25.
However, the patch itself is reasonable because the return value of
`temporary-file-directory' depends on `default-directory' - something we
don't want to do for `defvar' statement.
Could you please re-submit the patch altering the commit message stating
the reason I stated? Also, Please quote Elisp symbols in the commit
message as we usually do. See
https://orgmode.org/worg/org-contribute.html#commit-messages
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>