Re: [PATCH] lisp/org/ol.el: org-link-make-description-function is always applied

[Ihor Radchenko]

Feraidoon Mehri <feraidoonmehri@gmail.com> writes:

> The change is very small, so I think taking a look at the diff is more
> informative than I trying to explain it; the old code did not use
> `org-link-make-description-function` when some other alternatives were
> available, but my changes make it always use
> `org-link-make-description-function` if set.
>
> This change is a breaking API change, but I think the previous behavior was
> a bug. If you want to preserve the old behavior, perhaps we should add a
> new variable `org-link-postprocess-description-function`?

The truth is that old behaviour is not fully documented.
So, this part of code is extremely fragile.

See https://list.orgmode.org/orgmode/87mtb6w2rq.fsf@localhost/

May you go through the `org-insert-link' code and summarize its current
behaviour? Then, we can discuss further if and how we want to change it.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>