emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] testing: Delete duplicate tests


From: Max Nikulin
Subject: Re: [PATCH] testing: Delete duplicate tests
Date: Fri, 14 Jul 2023 18:50:39 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 13/07/2023 02:22, Ilya Chernyshov wrote:
+++ b/testing/lisp/test-ol.el
@@ -301,14 +301,6 @@ Seehttps://github.com/yantar92/org/issues/4.";
         (let ((file (buffer-file-name)))
         (equal (format "[[file:%s::two]]" file file)
                (org-store-link nil))))))
-  (should
-   (let ((org-stored-links nil)
-        (org-context-in-file-links t))
-     (org-test-with-temp-text-in-file "# two"
-       (fundamental-mode)
-       (let ((file (buffer-file-name)))
-        (equal (format "[[file:%s::two]]" file file)
-               (org-store-link nil))))))

The test was added by

7a78eb1be 2020-03-26 22:57:16 +0100 Nicolas Goaziou: ol: Fix some corner cases when normalizing context in links

The intention may be to test "#two" besides "# two". Maybe somebody has a better guess what case related to the change is not covered.

The idea to find duplicated tests is bright. The code may be transformed in a dedicated unit test. I would not drop existing tests blindly though.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]