Re: [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?)

[Henrik Frisk]

Den fre 11 aug. 2023 kl 09:04 skrev Ihor Radchenko <yantar92@posteo.net>:

Jonathan Gregory <jgrg@autistici.org> writes:

>> Jonathan, do you think that your original patch is still what
>> you want to get merged?
>
> Yes, the one I sent on 20 Jul 2023. I haven't had any issues with
> it so far.

Ok. Would you mind adding a commit message, as described in
https://orgmode.org/worg/org-contribute.html#first-patch?

And do I understand correctly that no changes in
https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html
are needed?

Sorry for being late in this discussion. As a user of ob-lilypond I'm very happy about these changes. On my last install, as well as my current I have had to change the following:

(org-babel-get-header params :var) which appears to be outdated, to:

(org-babel--get-vars params)

in the version of ob-lilypond.el from here: https://github.com/mjago/ob-lilypond/blob/master/lisp/ob-lilypond.el. Which version of the file are you patching now?

Another request would be to have the variables ly-XXX-pdf-path and ly-XXX-midi-path settable, or, perhaps, read from the lilypond settings of corresponding variables. I'm not an elisp programmer but I could look into that if it's of interest.

/Henrik