Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom)

[Ihor Radchenko]

Leo Butler <Leo.Butler@umanitoba.ca> writes:

>>> +(defconst org-babel-header-args:maxima
>>> +  '((batch               . :any)
>>
>> Why :any? Only two values are allowed here.
>>
>>> +    (graphics-pkg        . :any))
>>
>> Same. The value is a closed list.
>
> I have made the change requested.
>
> However, beyond the documentation value, I don't see this variable's
> values being used.

In completion. See `pcomplete/org-mode/block-option/src'.
Also, in org-lint. See `org-lint-wrong-header-argument'.

> Fixed. I don't use `apropos', so I didn't see the problem (and I had
> failed to absorb everything in §D.6).

M-x checkdoc checks for many of the §D.6 conventions.

> Please see the attached, revised patch. It fixes the problems that you
> have identified–except for the way that the gnuplot terminal is
> determined. I would like to leave that for a subsequent patch, mainly
> because this one has become quite large.

Ok. Thanks!

I have one more comment on the tests:

> +(ert-deftest ob-maxima/batch+verbatim+eof-error ()
> +  "Exercise the `:batch' header argument.  Send invalid input to
> +Maxima."
> +  (unwind-protect

What is the purpose of this `unwind-protect'?
In its current form, it does nothing because no UNWINDFORMS are
provided.

> +    (org-test-with-temp-text
> +        (format "#+name: ob-maxima/batch+verbatim+eof-error
> +#+begin_src maxima  :results verbatim :batch batch :cmdline --quiet
> +x:
> +#+end_src
> +")
> +      (should (string-match "end of file while scanning expression\\."
> +                            (org-babel-execute-src-block))))))



-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>