Re: [PATCH] org-bibtex-yank: Allow to populate existing item

[Martin Kampas]

On neděle 18. února 2024 15:29:09 CET Ihor Radchenko wrote:

> In the code, you do not check for t, but for non-nil. So, please say

> "non-nil" in the docstring as well.

As stated in the commit message, aligning with org-bibtex-create... ok, let me update the doc string of org-bibtex-create as well.

> Also, I'd prefer a more descriptive name, like update-heading. nonew is

> ambiguous - it can be interpreted in several ways.

...aligning with org-bibtex-create.

> > +  (interactive "P")

> > +  (let (entry

> > +        (noindent nonew))

>

> Why do you bind noindent here?

It says nothing about (re)indenting the existing entry, so my feeling was it would be better to avoid doing that if there is no way to override. Now if you need to ask about it, it seems it is not really an issue, so I removed it, hardcoding nil there.

BR,

Martin

0001-org-bibtex-yank-Allow-to-populate-existing-item.patch
Description: Text Data