Re: [Gnash-dev] Vitaly's #ifdef WIN32 checkins from Nov 24th

[strk]

John, belive me, we're all trying !
You can join the effort with group-replies against gnash-commit posts.

--strk;

On Mon, Nov 27, 2006 at 03:50:27AM -0800, John Gilmore wrote:
> Is there somebody on the team who can teach Vitaly Alexeev how to make
> gnash code more modular when it doesn't compile on WIN32?  He tends to
> patch in #ifdef "hacks", which is great for local testing and
> development.  But then he checks them into the main code base, rather
> than trying to understand the config scripts and provide a clean fix.
> 
> I can hardly blame him -- but perhaps with collaboration the code will
> port more easily and we'll all know a bit more about config scripts.
> Grepping the sources for "WIN32" will find lots of opportunities to
> move WIN32-specific hacks out of mainline code and into the config system.
> 
> Thanks folks -- the gnash project is moving along very well and quickly.
> It's all due to your efforts.
> 
>       John
> 
> Examples:
> 
> +/* $Id: extension.cpp,v 1.2 2006/11/24 14:41:39 alexeev Exp $ */
> ...
> -#if HAVE_DIRENT_H
> +#if HAVE_DIRENT_H || WIN32==1        // win32 hack
>  # include <dirent.h>
>  # define NAMLEN(dirent) strlen((dirent)->d_name)
>  #else
> ...
> 
> +++ ltdl.c    24 Nov 2006 14:42:21 -0000      1.3
> @@ -25,6 +25,19 @@
>  
>  */
>  
> +// win32 hack
> +#if defined(_WIN32) || defined(WIN32)
> +#define HAVE_STDLIB_H 1
> +#define HAVE_STDIO_H 1
> +#define HAVE_STRING_H 1
> +#define HAVE_CTYPE_H 1
> +#define HAVE_ERRNO_H 1
> +#define __WINDOWS__ 1
> +#define error_t int
> +#define LTDL_OBJDIR ""
> +#endif
> +
> +
>  #if HAVE_CONFIG_H
>  #  include <config.h>
>  #endif
> ...
> 
> Etc.
> 
>       John
> 
> 
> _______________________________________________
> Gnash-dev mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-dev

-- 

 /"\    ASCII Ribbon Campaign
 \ /    Respect for low technology.
  X     Keep e-mail messages readable by any computer system.
 / \    Keep it ASCII.