Hi,
Not sure how should I do github reviews (cannot see options to comment on particular patches), so there go some comments.
On Tue, Dec 4, 2018 at 10:20 PM Ladislav Michl <
address@hidden> wrote:
>
> From: Fabrizio Gennari <
address@hidden>
>
> Remove homebrew --enable-win option and use the standard autoconf way
> to cross-compile, that is using option --host.
In general it is OK, but some pieces do not belong here I think.
> - if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no"; then
> + if test "$enable_bluetooth" = "yes"; then
[...]
> - if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no"; then
> + if test "$enable_bluetooth" = "yes"; then
[...]
> -AM_CONDITIONAL([FOR_MAC], [test x$ac_cv_have_iobluetooth = xyes])
> + FOR_MAC=1
[...]
> - if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no"; then
> + if test "$enable_bluetooth" = "yes"; then
[...]
> - if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no"; then
> + if test "$enable_bluetooth" = "yes"; then
[...]
These seem to be unrelated. And even not sure why they are there? Also not sure why FOR_MAC would be dependent on iobluetooth.
Cheers,
--
Pawel Kot