Re: [PATCH v2 1/8] Use the native autoconf support for cross-compilation

[Ladislav Michl]

On Mon, Jan 13, 2020 at 07:37:02PM +0100, Pawel Kot wrote:
> Hi,
> 
> Not sure how should I do github reviews (cannot see options to comment on
> particular patches), so there go some comments.

Feel free to ignore to that pull request. I created it more likely as an
excercise (it is my first one there), just to practice before publishing
changes for rauc.

Once you are done with review, I'll send v3 here and also remove my clone
of gnokii from github.

> On Tue, Dec 4, 2018 at 10:20 PM Ladislav Michl <address@hidden> wrote:
> >
> > From: Fabrizio Gennari <address@hidden>
> >
> > Remove homebrew --enable-win option and use the standard autoconf way
> > to cross-compile, that is using option --host.
> 
> In general it is OK, but some pieces do not belong here I think.
> 
> > -       if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no";
> then
> > +       if test "$enable_bluetooth" = "yes"; then
> [...]
> > -       if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no";
> then
> > +       if test "$enable_bluetooth" = "yes"; then
> [...]
> > -AM_CONDITIONAL([FOR_MAC], [test x$ac_cv_have_iobluetooth = xyes])
> > +       FOR_MAC=1
> [...]
> > -       if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no";
> then
> > +       if test "$enable_bluetooth" = "yes"; then
> [...]
> > -       if test "$enable_bluetooth" = "yes" -a "$USE_BLUETOOTH" = "no";
> then
> > +       if test "$enable_bluetooth" = "yes"; then
> [...]
> 
> These seem to be unrelated. And even not sure why they are there? Also not
> sure why FOR_MAC would be dependent on iobluetooth.

This patch frees FOR_MAC from iobluetooth dependency. Removing
"$USE_BLUETOOTH" = "no" is an optimization and could be done in separate
patch, but it is done here to follow the same logic as
cygwin32|cygwin|mingw32|mingw32msvc case which is dealed with in this
patch.

Also note it is Fabrizio's patch and it seems unlikely he'll still care
after four years since original submission (but there is still room for
surprise). I didn't wanted to alter it more than needed, to preserve his
authorship.

> Cheers,
> --
> Pawel Kot

> _______________________________________________
> gnokii-users mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/gnokii-users